populate dimensions for restored json unit registries from dimensions namespace #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use "is" equality in a bunch of places when comparing dimensions. This is problematic given the current approach for the json saving and loading functionality, since
sympify
will generate distinctSymbol
objects. We could replace theis
equality uses with==
, but that is anywhere from a few times to 50 times slower:The solution for the particular instance of this issue we're running into here is to use the
locals
keyword argument forsympify
, which gives it access to a namespace of objects to substitute in expressions, which allows us to use the dimensions inunyt.dimensions
to populate the dimensions of the restored unit registries.